Skip to content

Fix memory no-cache usage calculation - #9

Merged
5o1 merged 1 commit into
mainfrom
fix/memory-used-zero
Jul 8, 2026
Merged

Fix memory no-cache usage calculation#9
5o1 merged 1 commit into
mainfrom
fix/memory-used-zero

Conversation

@5o1

@5o1 5o1 commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary:

  • compute memory used_no_cache_bytes from raw free/buffers/cached fields instead of subtracting cache from gopsutil Used
  • add FreeBytes to the memory collector model
  • cover the Cached > Used case that previously collapsed used_no_cache_bytes to 0

Tests:

  • GOCACHE=/tmp/workstation-probe-go-build go test ./internal/memory
  • GOCACHE=/tmp/workstation-probe-go-build go test ./...
  • webview/hugo/test/run.sh

Copilot AI review requested due to automatic review settings July 8, 2026 17:33
Copilot AI reviewed Jul 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@5o1
5o1 merged commit b978dfc into main Jul 8, 2026
4 checks passed
@5o1
5o1 deleted the fix/memory-used-zero branch July 8, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@5o1