Skip to content

Implement std::error::Error for ApiError#526

Merged
64bit merged 1 commit into64bit:mainfrom
BroderickCarlin:bcar/apierror-error
Feb 28, 2026
Merged

Implement std::error::Error for ApiError#526
64bit merged 1 commit into64bit:mainfrom
BroderickCarlin:bcar/apierror-error

Conversation

@BroderickCarlin
Copy link
Copy Markdown
Contributor

The ApiError currently does not implement the std::error::Error trait, unlike many of the other error types within this crate. This can make errors of the ApiError type less ergonomic to handle within frameworks than may expect generic errors.

Simple 1-line fix to just implement std::error::Error with all default methods, given that ApiError already implements Debug and Display

Copy link
Copy Markdown
Owner

@64bit 64bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the context in description and PR!

@64bit 64bit merged commit b8fe49a into 64bit:main Feb 28, 2026
148 checks passed
@BroderickCarlin BroderickCarlin deleted the bcar/apierror-error branch February 28, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants