Skip to content

Plugin manager improvements #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itisFarzin merged 3 commits into from
Jul 28, 2026
Merged

Plugin manager improvements #32

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
333be39
refactor(core): simplify handler group calculation
itisFarzin Jul 28, 2026
5ea4198
refactor(core): use equality for plugin name filter
itisFarzin Jul 28, 2026
8380474
chore(core): improve warning messages
itisFarzin Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions bot/core/plugin_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,7 @@ def module_handlers(

for handler, group in handlers:
if isinstance(handler, Handler) and isinstance(group, int):
group = (
0
if (group < 0 and group_offset != 0)
else (group + group_offset)
)
group = max(group + group_offset, 0)
yield (handler, group)

def get_handlers(
Expand Down Expand Up @@ -159,7 +155,7 @@ def get_plugin_status(self, plugin: str) -> bool:
with Session(Settings.engine) as session:
enabled = session.execute(
select(PluginDatabase.enabled).where(
PluginDatabase.name.is_(plugin)
PluginDatabase.name == plugin
)
).scalar()
return bool(enabled)
Expand Down Expand Up @@ -210,7 +206,7 @@ def custom_load_plugins(
else:
result[callback_name] = "Failed to load handler"
logging.warning(
f"Failed to load {callback_name} handler, "
f"Failed to load {callback_name} handler "
"because it is already loaded"
)

Expand Down Expand Up @@ -239,7 +235,7 @@ def unload_plugins(
result[callback_name] = "Failed to unload handler"
logging.warning(
f"Failed to unload {callback_name} handler, "
"it is not loaded already."
"it is not loaded."
)

return result
Expand Down