Support returnable zeroperl command artifact#28
Open
sureshchouksey8 wants to merge 1 commit into
Open
Conversation
Author
|
/claim #23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the open direction in #24 by @mt211211 and keeps the host-callback / returnable-command approach intact. I am submitting it as a clean branch without workflow-file changes because my available GitHub token cannot push
.github/workflows/*updates.Targeted issue: #23, especially the latest tester report on #24:
indirect call to nullafter the prior_start,unreachable executed, and asyncify-state fixes.What changed:
zeroperl_command.wasmpath with returnable_startWhy:
The remaining trap appears after the command path is able to return. A plausible failure path is post-run global teardown in the browser/WASI shim rather than the script execution itself. For this command artifact, the Wasm instance is one-shot, so instance disposal can reclaim state instead of forcing Perl global teardown from
_start.Validation I could run here:
git diff --checkstubs/zeroperl_main.cno longer referenceszeroperl_shutdown()and contains the one-shot command wrapper commentNot run locally:
Credit:
This is intentionally based on the implementation/debugging already done in #24 by @mt211211. The additional change I am adding is the command-wrapper teardown avoidance for the latest
indirect call to nullreport.