feat: make dance.openMenu retain count/register state#389
Draft
Conversation
Before this change, many/most of the unit tests failed due to line ending discrepancies, irrespective of the line endings stored in the test suite source files. After the change, they all pass, again irrespective of the files' line endings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #375 with an additional commit which renames
keepephemeraltokeepcontextas it reads better to me.NOTE: Does not work yet; the context is kept even after the command selected by the menu runs, which is unexpected. I tried to instead forward args to the menu using
..., but it doesn't work with inner objects, so more work is needed there.