Conversation
Refactor: extract delete and deletion-related commands (such as change) from the insert function into a new function named `deleteSelections` Testing: ``` yarn test ``` TODO separate tests for deletion too
Introduce new commands to delete while preserving lines, similar to how it is done in Helix. Before this change, running `xc` in helix would delete the current line and place the cursor at the new line. After this change, `xc` will now clear a line but keep an empty line, where the cursor will start at. Test Plan: See new tests inside edit-insert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce new commands to delete while preserving lines, similar to how it is done in Helix.
Before this change, running
xcin helix would delete the current line and place the cursor at the new line.After this change,
xcwill now clear a line but keep an empty line, where the cursor will start at.Test Plan:
See new tests inside edit-insert