Feat: Fix to Yearly Heat Map Instead of Monthly Heat Map#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Heatmap Tab (
heatmap_tab.py) — Full Rewrite#ebedf0to#216e39) with quartile-based thresholdsRepository (
transaction_repository.py)get_daily_spending_for_year(year)— returns daily spending totals keyed by ISO date stringget_years_with_expenses()— returns sorted descending list of years that have expense dataStatistics Service (
statistics.py)get_yearly_heatmap_data(year)— delegates to the new repository methodget_available_years()— delegates to the new repository methodMain Window (
main_window.py)_refresh_active_tab()to refresh whichever tab is currently visible_refresh_active_tab()instead of hardcodedtransactions_tab.refresh()_on_tab_changed()simplified to delegate to_refresh_active_tab()Test Plan
get_daily_spending_for_year()andget_years_with_expenses()intests/core/test_repository.pyget_yearly_heatmap_data()andget_available_years()intests/services/test_statistics.py