feat: add category spending bar chart to Statistics tab#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Repository layer
get_spending_by_category(start_date, end_date)method onTransactionRepository— same query asget_top_spending_categorybut returns all categories instead ofLIMIT 1, sorted descending by total spendingService layer
get_monthly_category_breakdown(year, month)onStatisticsService— delegates to repository after converting year/month to date range via existing_get_month_date_range()GUI
Canvaswith mousewheel support (handles both macOS and Windows delta conventions)Tests
Design decisions
num_categories * (bar_height + gap)so the box fits its content exactlyevent.deltais small (1/-1) while Windows uses multiples of 120; handled viaplatform.system()check🤖 Generated with Claude Code