Favorite a video straight from the queue - #10
Merged
Conversation
Add a star button to each queue item so videos in the queue can be favorited or unfavorited without having to wait for them to play. Toggling a queue item's favorite status immediately updates local storage, the favorites panel, the now-playing star button, and all queue item stars across the UI. If a video is favorited from the queue while not actively playing, its initial watch count starts at 0 plays. Fixes 7akob#9
Owner
|
Thanks @prateeekbuilds I will merge this now, looks great! Any other issue you would like to take? Also happy to open something new if you have an idea of your own instead. |
Author
|
Thanks @7akob! I’d be happy to take on another issue. I’ll look through the open issues, and I’ll let you know if I come up with any ideas too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a star button to each queue item so videos in the queue can be favorited or unfavorited without having to wait for them to play.
Toggling a queue item's favorite status immediately updates local storage, the favorites panel, the now-playing star button, and all queue item stars across the UI. If a video is favorited from the queue while not actively playing, its initial watch count starts at 0 plays.
Fixes #9