Refactor Settings UI and Add Info Component#36
Merged
Conversation
7sg56
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
##Key Changes:
New Components:
Info.tsx (+110 lines) - New settings information component
Settings.tsx (+181 lines) - Unified settings component combining previous separate settings modules
Removed Components:
AccountSettings.tsx (-129 lines) - Consolidated into new structure
GeneralSettings.tsx (-120 lines) - Merged into unified settings
ThemeSettings.tsx (-304 lines) - Merged into unified settings
Minor Updates:
FloatingHub.tsx: Adjusted by 7 additions, 20 deletions
Editor.tsx & EditorTabs.tsx: Small refactoring (8 changes each)
cinderTheme.ts: Theme adjustments (11 additions, 13 deletions)
markdown.css: Styling updates (18 additions, 25 deletions)
Net Result:
+341 additions, -625 deletions - Overall reduction in code while improving component organization and maintainability.