This repository was archived by the owner on Mar 10, 2026. It is now read-only.
fix: in-app notification banner placement#253
Open
Just-Insane wants to merge 3 commits into7w1:devfrom
Open
Conversation
added 2 commits
March 8, 2026 14:37
- render NotificationBanner in ClientLayout so it spans the full viewport as position:fixed and doesn't displace page content - remove the old banner render from Room.tsx
dozro
approved these changes
Mar 8, 2026
Owner
I... don't see that in the code? Only the addition of one in ClientLayout. Guessing it got bundled into a different PR. |
Collaborator
Author
|
Ah... that could be. I'll take a look in a little bit. |
Completes the placement move — banner is now rendered only in ClientLayout as position:fixed.
Collaborator
Author
|
Should be good now |
Just-Insane
pushed a commit
to CloudHub-Social/sable
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotificationBannerwas rendered insideRoom.tsx, meaning:Fix
Move the single
<NotificationBanner />render point toClientLayout.tsx. The banner CSS is updated toposition: fixed; top: 0; left: 0; right: 0so it overlays content without shifting the layout.Changed files
src/app/pages/client/ClientLayout.tsx<NotificationBanner />rendersrc/app/features/room/Room.tsx<NotificationBanner />rendersrc/app/components/notification-banner/NotificationBanner.css.tsposition: fixed; top/left/right: 0