add client id rotation with lazy probe and 401 retry - #23
Open
feralbureau wants to merge 1 commit into
Open
Conversation
- SoundCloud.__init__() gains extra_client_ids param for a pool of fallback IDs - client_id becomes a property with lazy validation: probes the pool on first use, skipping known-invalid IDs, and falls back to generate_client_id() if all are dead - _invalidate_client_id() marks current ID as invalid and triggers lazy re-probe - refresh_client_id() public method for manual rotation - All 4 request classes (Request, CollectionRequest, ListRequest, GraphQLRequest) now catch 401 responses, invalidate the client ID, and retry once - New NoValidClientIDError raised when all pool IDs fail and generation also fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add extra_client_ids param to SoundCloud.init() for a pool of fallback ids
client_id becomes a property with lazy validation: probes on first use,
skips known-invalid ids, falls back to generate_client_id() if all are dead
_invalidate_client_id() marks current id as invalid and triggers lazy re-probe
refresh_client_id() public method for manual rotation
all 4 request classes (Request, CollectionRequest, ListRequest, GraphQLRequest)
now catch 401 responses, invalidate the client id, and retry once
new NoValidClientIDError raised when all pool ids fail and generation also fails