v0.4.0 Wave 17: local comments (anchored threads, reply/resolve/assign, PPTX persistence) - #15
Merged
Merged
Conversation
…Wave 17, component 3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 17 adds local comments — threaded annotations anchored to slides, shapes, or text ranges. Support reply, resolve, assignment, and deletion. Comments persist in the PPTX custom XML manifest and survive round-trip.
What changed
Model (
slides-core)Comment,CommentThread,CommentAnchor(slide / shape / text-range). AdditiveDeck.comments(#[serde(default)]).AddComment,ReplyToComment,SetCommentResolved,AssignComment,DeleteCommentThread.PPTX (
slides-pptx)]]>to prevent corruption from comment bodies containing that sequence (found during review).]]>edge case.Desktop (
apps/desktop/)Comments.svelte, +697 lines): toggle withC, threads grouped by slide, reply/resolve/assign/delete.@html(no XSS).Review process
Control-tower pipeline applied: review subagent (mechanical line-by-line) + contextual triage. One WARNING found and fixed before merge (CDATA
]]>injection). No CRITICAL issues.Test results
npm run check(svelte-check): 0 errors, 0 warnings.scripts/verify-local.sh: green.scripts/verify-public-release.sh: green.