DFTandSpectralWindow improvement#598
Merged
Merged
Conversation
Collaborator
mpyat2
commented
May 8, 2026
mpyat2
commented
- While calculating trigonometric functions (sin, cos), the time interval is centered to reduce possible numerical instability.
- The near-zero frequency cutoff takes into account the number of harmonics used to calculate the periodogram in multi-harmonic mode.
- The "Recommended Resolution" button sets the resolution to 0.05 / timeSpan / harmonicCount. In the frequency domain, FWHM ~ 1 / (timeSpan × harmonicCount), meaning there will be approximately 20 points across the peak top.
Contributor
Plugin Unit TestsAll tests passed (Java 17)
|
Contributor
VStar Unit TestsAll tests passed (Java 17)
|
dbenn
approved these changes
May 8, 2026
github-project-automation
Bot
moved this from To do
to In progress
in VStar Development Issues
github-project-automation
Bot
moved this from In progress
to Done
in VStar Development Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.