#579: add boolean show constructors to AboutBox and MultiEntryComponentDialog#602
Merged
Conversation
…ntDialog Decouple both dialogs from Mediator.getUI() to enable headless testing. * AboutBox: add package-private AboutBox(boolean show) constructor that skips UI panel building, setLocationRelativeTo, and setVisible when show=false; the public no-arg constructor delegates with show=true. * MultiEntryComponentDialog: add package-private 5-arg constructor (title, helpTopic, fields, additionalUIComponent, show) that guards setLocationRelativeTo and setVisible behind show; the existing public 4-arg constructor delegates with show=true — all other overloads are unchanged. * Add AboutBoxTest and MultiEntryComponentDialogTest exercising the new show=false path; register both in AllTests.java. Co-authored-by: Cursor <cursoragent@cursor.com>
dbenn
added
verification
Contributor
Plugin Unit TestsAll tests passed (Java 17)
|
Contributor
VStar Unit TestsAll tests passed (Java 17)
|
…ryComponentDialogTest Tests pass correctly under ant test locally. Co-authored-by: Cursor <cursoragent@cursor.com>
…onentDialog Clarify that package-private visibility enables test construction without display, rather than implying tests are the only caller. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple both dialogs from Mediator.getUI() to enable headless testing.