579 more dialogs and models#603
Merged
Merged
Conversation
Add -o flag to unzip so existing files in _site/plugins/snapshot/ are overwritten without an interactive prompt, which caused CI to fail with exit code 1 when the .plugins.lst file already existed. Co-authored-by: Cursor <cursoragent@cursor.com>
…plugin patterns Workstream A — AbstractOkCancelDialog subclasses: - PolynomialDegreeDialog: add package-private (int, int, boolean show) constructor; PolynomialDegreeDialogTest covers title, modality, isCancelled, initial degree, okAction/cancelAction. - RadioButtonDialog: add package-private (String, Collection, String, boolean show) constructor; RadioButtonDialogTest covers title, modality, isCancelled, selectedOption default, okAction/cancelAction. - DiscrepantReportDialog: add package-private (String, ValidObservation, boolean show) constructor; DiscrepantReportDialogTest covers title, modality, isCancelled, initial comments, cancelAction. - PhaseParameterDialog: constructor already safe (no Mediator.getUI call); PhaseParameterDialogTest covers title, modality, initial period/epoch, field setters. - SeriesTypeCreationDialog: constructor already safe (no Mediator.getUI call); SeriesTypeCreationDialogTest covers title, modality, isCancelled, cancelAction. Workstream B — Period-analysis plugin dialog patterns (placed in org.aavso.tools.vstar.ui.dialog to access package-private 5-arg constructor): - PeriodAnalysisPluginDialogsTest replicates and tests the exact DoubleField configurations used by DcDftFrequencyRangePeriodAnalysisPlugin, DcDftPeriodRangePeriodAnalysisPlugin, WeightedWaveletZTransformWithPeriodRangePlugin, and WeightedWaveletZTransformWithFrequencyRangePlugin. Workstream C — all GUI-classified table/list models already tested; no new candidates. All new tests registered in AllTests.java. Co-authored-by: Cursor <cursoragent@cursor.com>
dbenn
added
verification
Contributor
Plugin Unit TestsAll tests passed (Java 17)
|
Contributor
VStar Unit TestsAll tests passed (Java 17)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.