CliCommand.run optionally return exit code#248
Open
TimothyWillard wants to merge 1 commit intomainfrom
Open
Conversation
Updated the `CliCommand.run` method's return signature to `ExitCode | None` where `ExitCode` is a new `IntEnum` added to `flepimop2.typing`. This creates consistent exit codes across CLI commands. Closes #17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the
CliCommand.runmethod's return signature toExitCode | NonewhereExitCodeis a newIntEnumadded toflepimop2.typing. This creates consistent exit codes across CLI commands.Related issues
Closes #17.
Checklist
just ci.CHANGELOG.mdor noted "no major changes" in my commit if the PR is small.