Add module attr to OpEngineFlepimop2Engine#17
Merged
TimothyWillard merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
Added required `module` attribute to the `OpEngineFlepimop2Engine` class. Also updated the integration test's configuration to set 'state_change' for the wrapper system. Also addressed ruff linting errors, namely D420. Closes #15.
TimothyWillard
force-pushed
the
push-okopmsrosrrr
branch
from
02a2fb4 to
999cb08
Compare
TimothyWillard
changed the title
module attr to OpEngineFlepimop2Engine
jc-macdonald
approved these changes
Mar 19, 2026
Collaborator
jc-macdonald
left a comment
jc-macdonald
left a comment
There was a problem hiding this comment.
LGTM, thanks @TimothyWillard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added required
moduleattribute to theOpEngineFlepimop2Engineclass. Also updated the integration test's configuration to set
'state_change' for the wrapper system.
Also addressed ruff linting errors, namely D420.
Closes #15.