Replace system._stepper with public system.bind() API#50
Merged
jc-macdonald merged 3 commits intomainfrom Apr 9, 2026
Merged
Conversation
Update flepimop2 from pinned commit 43143a6 to @main, picking up the SystemABC.bind() API from PR #182. Fix IdentifierString import which moved from flepimop2.configuration to flepimop2.typing.
Add test_engine_uses_bind_not_stepper which instruments system.bind() to verify the engine calls the public API rather than accessing the private _stepper attribute directly.
jc-macdonald
added
provider
pearsonca
approved these changes
Apr 9, 2026
Member
pearsonca
left a comment
pearsonca
left a comment
There was a problem hiding this comment.
see other PR response; LGTM as minimal approach
TimothyWillard
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the last private attribute access (
system._stepper) in the engine provider with the publicsystem.bind()API introduced in flepimop2 PR #182.Changes
43143a6→@main(post-PR #182). FixedIdentifierStringimport which moved fromflepimop2.configurationtoflepimop2.typing.system._stepper→system.bind()— One-line change on line 162, removing the# noqa: SLF001suppression._GoodSystemnow implements_bind_impl()usingfunctools.partial, matching flepimop2's reference pattern.test_engine_uses_bind_not_stepperinstrumentssystem.bind()to confirm the engine calls the public API.Related
getattrintrospection withsystem.option()for mixing kernels #42system._stepperaccess with public bind API #49system._stepperaccess with public bind API op_system#55 (system-side_bind_impl, PR #57)