Skip to content

fix: align provider mypy/test with op_engine pattern #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jc-macdonald merged 1 commit into from
Apr 8, 2026
Merged

fix: align provider mypy/test with op_engine pattern #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions flepimop2-op_system/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,6 @@ ignore = [
[tool.ruff.lint.pydocstyle]
convention = "google"

[tool.mypy]
strict = true
files = "."
namespace_packages = true
explicit_package_bases = true
mypy_path = "$MYPY_CONFIG_FILE_DIR/src"

[dependency-groups]
dev = [
"pytest>=8.4.2",
Expand Down
15 changes: 11 additions & 4 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,15 @@ test-root:
# Run the provider package test suite
[group('dev')]
[group('ci')]
test-provider:
{{provider_run}} pytest
test-provider: provider-sync
cd {{provider_dir}} && .venv/bin/python -m pytest

# Create/refresh the provider venv and install all deps (including dev group).
# Run this once before running provider pytest/mypy if you aren't using `ci`.
[group('dev')]
provider-sync:
cd {{provider_dir}} && uv venv --clear
cd {{provider_dir}} && uv sync --dev

# Run type checks in both packages
[group('dev')]
Expand All @@ -90,8 +97,8 @@ mypy-root:
# Run mypy for the provider package
[group('dev')]
[group('ci')]
mypy-provider:
{{provider_run}} mypy
mypy-provider: provider-sync
cd {{provider_dir}} && .venv/bin/python -m mypy --strict --namespace-packages --explicit-package-bases src/flepimop2

# Run all CI quality checks
[group('ci')]
Expand Down
Loading