feat(compile): thread meta from NormalizedRhs through CompiledRhs#53
Merged
jc-macdonald merged 3 commits intomainfrom Apr 8, 2026
Merged
feat(compile): thread meta from NormalizedRhs through CompiledRhs#53jc-macdonald merged 3 commits intomainfrom
jc-macdonald merged 3 commits intomainfrom
Conversation
Add a Mapping[str, Any] meta field to CompiledRhs with an empty MappingProxyType default. Existing callers are unaffected — the field is optional and backward-compatible. Part of #11.
Pass rhs.meta to CompiledRhs in compile_rhs(), preserving axes, kernels, and operators metadata through the compile pipeline. Part of #11.
Verify that: - compile_rhs preserves axes and kernels metadata - bare specs produce empty meta collections - compile_spec facade round-trips meta end-to-end Refs: #11
bde0ba7 to
3727f71
Compare
TimothyWillard
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Summary
NormalizedRhs.meta(axes, kernels, operators, etc.) was dropped during compilation —CompiledRhshad nometafield. This meant downstream consumers (e.g. the flepimop2 provider) couldn't access structural metadata without re-normalizing the spec.Changes
meta: Mapping[str, Any]field toCompiledRhs(defaults to emptyMappingProxyType({}))rhs.metathrough incompile_rhs()compile_specfacade end-to-end2 files changed, +56 lines across 3 focused commits.
Commits
fdcf105—feat(compile): add meta field to CompiledRhs3b27f19—feat(compile): thread meta from NormalizedRhs through compile_rhs922cdc3—test(compile): add meta threading tests