chore: silence false-positive dead_code warnings#57
Merged
Conversation
The crate emitted 16 "never used" warnings on the native build. All are false positives: the Soroban contract macros generate the entrypoints (deploy / deploy_sponsored / is_vault), so the native dead-code linter can't see that the helper/storage/event fns are reachable. Every item has a real call site and the WASM build reports 0 warnings. Add crate-level #![allow(dead_code)], matching vc-vault's lib.rs.
📝 WalkthroughWalkthroughAdded a crate-level compiler attribute ChangesDead-code warning suppression
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
vc-vault-factorycrate emitted 16never usedwarnings on the native build. All are false positives: the Soroban contract macros (#[contract],#[contractclient],#[contractimpl]) generate the entrypoints (deploy/deploy_sponsored/is_vault), so the native dead-code linter can't see that the helper / storage / event functions are reachable through them.Every flagged item has a real call site, and the WASM build (the real target) reports 0 warnings.
Change
Add crate-level
#![allow(dead_code)]tocontracts/vc-vault-factory/src/lib.rs, matching the pattern already used invc-vault'slib.rs.Evidence (0 dead code)
derive_saltdeploy_vaultextend_instanceget_vault_init_metaset_deployedis_deployedvault_deployed/sponsored_vault_deployed