Update docs for 0.16.0 update of asdf Golang version#12
Draft
Conversation
timkinnane
reviewed
Mar 2, 2025
Collaborator
timkinnane
left a comment
There was a problem hiding this comment.
This looks good @Skeeg, thanks for contributing.
I made a similar change locally just a couple days ago after finding that sourcing asdf.sh hasn't been required for quite a while.
I left the environment file loading though because I had to add some other values to get plugins working, e.g:
export ASDF_DIR="$HOME/.asdf"
export ASDF_DATA_DIR="$HOME/.asdf"
export PATH="${ASDF_DATA_DIR:-$HOME/.asdf}/shims:$PATH"
export ASDF_CONCURRENCY=autoI'm not sure any of that is actually necessary though, or just a problem with the Node plugin version.
I'd be okay with your changes as is for now if you take them out of draft, then we can see about moving to Mise as a follow up. It does seem a lot easier to setup and maintain so far.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.