Skip to content

V2.0 Fix for Issue #250: Dashboard does not reflect changes to node over time - #361

Merged
AileenCleary merged 4 commits into
mainfrom
aileen/issue250v2
Aug 26, 2026
Merged

V2.0 Fix for Issue #250: Dashboard does not reflect changes to node over time#361
AileenCleary merged 4 commits into
mainfrom
aileen/issue250v2

Conversation

@AileenCleary

Copy link
Copy Markdown
Collaborator

PR Info

Fix for Issue #250.

Dashboard NodeModal was slow to update changes in node information or actions. Page was stale and needed to be manually refreshed or opened and closed, and the refresh time default was 01:00 minutes.

Changes

1. Reduce node_info_update_interval default from 60.0 to 30.0.

By decreasing the default value of node_info_update_interval, the workcell will more frequently query node information, therefore detecting any changes made and updating the dashboard.

2. Fix the UI by having NodeModal use computed property over modal_text.

Currently, NodeModal uses props.modal_text to feed into NodeInfoTab and NodeActionsTab, which is a snapshot that is only captured once when the modal is opened. Thus, even if wc_state updates later with new node information, modal_text will not change. Instead, we now use a computed property current_node_info that reads directly from wc_state.nodes[modal_title].info. Because wc_state is reactive, current_node_info will automatically update when the workcell manager pushes new node information into the workcell state.

Additional fixes have been made to pass all available tests.

Developer Checklists

I have:

  • Run Pre-commit and Unit Tests, and ensured that they pass
  • Created or updated documentation relevant to your change
  • Created or updated unit tests relevant to your change

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/madsci_client/madsci/client
  event_client.py
  src/madsci_common/madsci/common/types
  workcell_types.py
Project Total  

This report was generated by python-coverage-comment-action

@AileenCleary
AileenCleary requested a review from tginsbu1 August 18, 2026 14:37
@AileenCleary AileenCleary self-assigned this Aug 18, 2026
@AileenCleary AileenCleary linked an issue Aug 18, 2026 that may be closed by this pull request
@AileenCleary
AileenCleary marked this pull request as ready for review August 18, 2026 14:37

@tginsbu1 tginsbu1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue, good job.

@AileenCleary
AileenCleary merged commit fca1530 into main Aug 26, 2026
4 checks passed
@AileenCleary
AileenCleary deleted the aileen/issue250v2 branch August 26, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Dashboard Does Not Reflect Changes to Node Info Over Time

2 participants