Skip to content

addmomitor and swap#51

Open
ndefokou wants to merge 6 commits into
mainfrom
feature-10-monitoring-ram-and-swap-usage
Open

addmomitor and swap#51
ndefokou wants to merge 6 commits into
mainfrom
feature-10-monitoring-ram-and-swap-usage

Conversation

@ndefokou
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing you know now how to use the psutil liib. Now, use it in a better way, and push something here again

Comment thread app.py
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yeah but no. Your code is working, isn't it? But now, see how I did the implementation for the CPU. First a service, then I import it in the app, the use it

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is working very fine

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what i am to add in the code

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analyse how the code for the CPU is done to inspire you

Copy link
Copy Markdown
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work already. Now, try to copy the rest of the project to understand what you need to do

Comment thread services/__pycache__/cpu_service.cpython-310.pyc Outdated
Comment thread services/__pycache__/memory_service.cpython-310.pyc Outdated
Comment thread services/__pycache__/ram_and_swap_usage.cpython-310.pyc Outdated
Comment thread services/__pycache__/time_service.cpython-310.pyc Outdated
Comment thread services/ram_and_swap_usage.py Outdated
Copy link
Copy Markdown
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update these too:

Comment thread app.py
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analyse how the code for the CPU is done to inspire you

Comment thread app.py Outdated
return jsonify(ram_usage_history=ram_usage, swap_usage_history=swap_usage)


ram_and_swap_usage
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding it here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

becouse the ram and the swap are all in the memory

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. This is not correct ode. Please fix

Copy link
Copy Markdown
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good research @ndefokou! Now I could see that Someone else was doing the same thing, @Motouom in #65

Comment thread conduct.py
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has nothing to do with this ticket

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check @Motouom's implementation at #65

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay sir but it was nice to search and you help me understand it thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants