Review User Story #19#54
Conversation
stephane-segning
left a comment
stephane-segning
left a comment
There was a problem hiding this comment.
Very good work 😎, as always @sinke237. But you missed a point. Look at this CPU Service https://github.com/ADORSYS-GIS/monitor-mind/blob/main/services/cpu_service.py#L6 where I cheated and used a Python dictionary to save data to, in a key-value form. What I'm expecting from you, is to make this saving better, by, as you already started, using sqlite there 👌🏿
|
|
||
| return render_template('historic_data.html', data=data) | ||
|
|
||
| def collect_metrics(): |
There was a problem hiding this comment.
Very good! Now you can put this into each service, instead of in the main entry point of this app 😊
There was a problem hiding this comment.
put it into each service, I'm sorry I am sure I understand what you mean.
There was a problem hiding this comment.
You could see that each resource had a single responsible in "services" folder. The idea is to separate each
There was a problem hiding this comment.
Wait, so I am supposed to have 11 .py files inside the services folder??
ghost
force-pushed
the
feature/19-historical-data-storing-viewing
branch
from
e9c493f to
dbc9889
Compare
2 participants
Hello, take time to review what i have done so far. I appreciate your feedback.