Skip to content

pytest framework for the project#58

Open
Ngha-Boris wants to merge 5 commits into
mainfrom
39-set-up-a-testing-framework-for-the-project
Open

pytest framework for the project#58
Ngha-Boris wants to merge 5 commits into
mainfrom
39-set-up-a-testing-framework-for-the-project

Conversation

@Ngha-Boris
Copy link
Copy Markdown
Collaborator

ticket 39 set up a testing framework for the project

@Ngha-Boris Ngha-Boris linked an issue Nov 10, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should take a look at these points.

Comment thread templates/index.html
Copy link
Copy Markdown
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review it

Comment thread .gitignore Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file too

Comment thread __pycache__/conftest.cpython-310-pytest-7.4.3.pyc
Comment thread __pycache__/app.cpython-310.pyc
Copy link
Copy Markdown
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work till now @Ngha-Boris ! Keep on going:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sir thank you

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Comment thread templates/index.html
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change here? Did you implemented the network?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To learn how to revert changes when working with git, check this link https://www.atlassian.com/git/tutorials/undoing-changes/git-revert

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sir

Comment thread .gitignore
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good. First read how to exclude files on git. Then remove everything here and make it better. The idea is to exclude the folder __pycache__:

venv
.vscode
.idea
__pycache__ # <-- simpler done like this

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sir thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up a testing framework for the project.

2 participants