fix tc alignment for fd waveforms in pycbc plugin#4
Open
Kanchan-05 wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @Kanchan-05 The developer kindly noticed me that "test reproducing the issue and showcasing this is solved in a unit test." is required to accept a PR. Also, a github PR is not used for this project, could you send an email with patch instead (https://github.com/AEI-ACR/pyseobnr/blob/main/.github/PULL_REQUEST_TEMPLATE.md). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the time of coalescence (t_c) alignment for frequency-domain (FD) waveforms returned through the PyCBC plugin. The current implementation introduces a mismatch between the expected and actual peak time of the waveform. This change corrects the time offset by shifting the waveform so that its peak occurs at t = 0.