Skip to content

Feature/29 member service crud#87

Merged
raphael-frank merged 32 commits into
mainfrom
feature/29-member-service-crud
Jun 26, 2026
Merged

Feature/29 member service crud#87
raphael-frank merged 32 commits into
mainfrom
feature/29-member-service-crud

Conversation

@f-s-h

@f-s-h f-s-h commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Implemented Memberservice accoroding to the documentation including MemberService and Keycloakservice.

Closes #29

f-s-h added 28 commits June 9, 2026 11:46
@f-s-h
Moved HelloController to controller/HelloController
f34aee3
@f-s-h
Implemented placeholder MemberController and MemberService
54045fa
@f-s-h
Implemented test for getAllMembers
d6f6507
@f-s-h
Deleted redundant MemberDTO
159e569
@f-s-h
Implemented getAllMembers() in MemberController
3b1a3f7
@f-s-h
Added comments for test cases
e4ac893
@f-s-h
Added comment describing getAllMembers
1fe590b
@f-s-h
Placeholder for getMemberById
8e11443
@f-s-h
Added tests for getMemberById
2e2f4ca
@f-s-h
Removed UUID type test, as SpringBoot automatically returns 400 if th…
a09d55d 
…e PathVariable is not of type UUID
@f-s-h
Added @beforeeach setup that creates a Member used for testing
2f786c1
@f-s-h
Implemented getMemberById endpoint
9298977
@f-s-h
Implementd createUser in KeycloakService that creates a user in Keycl…
33ec9c0 
…oak with the default role "member"
@f-s-h
Implement createMember
c25a0cc
@f-s-h
Implemented updateMember
55f6037
@f-s-h
Implemented getMemberDetails
d2d5313
@f-s-h
Implemented deleteMember
be3c85b
@f-s-h
Merge remote-tracking branch 'origin/main' into feature/29-member-ser…
19705ca 
…vice-crud
@f-s-h
Merge branch 'main' into feature/29-member-service-crud
2a85599
@f-s-h
Renamed from MemberServiceApplicationTests.java to MemberServiceAppli…
4f07cb1 
…cationTest.java
@f-s-h
Renamed getMemberById to getMemberSummaryById and getMemberDetailsByI…
a5aed03 
…d to getMemberById
@f-s-h
Implemented MemberConverter
1c4740c
@f-s-h
Moved Tests to subfolder
8f62244
@f-s-h
Removed unnecessary Test
e8320f8
@f-s-h
Added AllArgsConstructor
4c6421c
@f-s-h
Implemented KeycloakService
895e9f8
@f-s-h
Implemented equals
66e1a94
@f-s-h
Implemented MemberService
bdc395f
@f-s-h f-s-h requested a review from raphael-frank June 19, 2026 12:01
@f-s-h f-s-h self-assigned this Jun 19, 2026
@raphael-frank

raphael-frank commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator
  • Fixed several bugs in the member CRUD implementation found during a review against the other services
  • Aligned the API responses with the OpenAPI spec (e.g. email conflict now correctly returns 409)
  • Cleaned up the update flow to only patch fields that are actually provided
  • Fixed a security issue where the wrong ID was used for the self-update permission check
  • Added password support when creating members in Keycloak

Rest lgtm!

@FadyGergesRezk

FadyGergesRezk commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Guys, where is the members/dashboard endpoint?

@raphael-frank

raphael-frank commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Guys, where is the members/dashboard endpoint?

I will add the api stuff we discussed in a different PR and migrate the already implemented services, I didnt want to throw away progress.

@raphael-frank raphael-frank merged commit 8a8cb5c into main Jun 26, 2026
17 checks passed
@raphael-frank raphael-frank deleted the feature/29-member-service-crud branch June 26, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raphael-frank raphael-frank raphael-frank approved these changes

Assignees

@f-s-h f-s-h

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Implement CRUD Endpoints for Members in Member Service

3 participants

@f-s-h @raphael-frank @FadyGergesRezk