Skip to content

Proj i08/fix terraform region#113

Merged
georges-nasrallah merged 2 commits into
mainfrom
PROJ-I08/fix-terraform-region
Jul 2, 2026
Merged

Proj i08/fix terraform region#113
georges-nasrallah merged 2 commits into
mainfrom
PROJ-I08/fix-terraform-region

Conversation

@georges-nasrallah

@georges-nasrallah georges-nasrallah commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix Azure region and restore OIDC environment binding so the cd-dev workflow can provision the AKS cluster.

Closes #PROJ-I08


Motivation & Context

The CD pipeline failed because (1) the Azure subscription policy disallows westeurope, and (2) the OIDC federated credential subject expects environment:dev but the workflow was missing that setting.


Changes

  • Switch Terraform default region from westeurope to germanywestcentral
  • Restore environment: dev to the cd-dev workflow job so the OIDC subject matches the federated credential

Steps for Testing

  1. Merge to main and trigger CD - Dev (AKS) workflow
  2. Verify Azure login, Terraform apply, and Ansible deploy all pass

Checklist

  • I have self-reviewed the diff
  • Code is clean — no debug statements, commented-out code, or TODOs left behind
  • All CI checks pass (build · test · lint)
  • Tests added or updated to cover the changes (if needed)
  • New env vars added to .env.example
  • OpenAPI spec updated and codegen re-run (make -C api generate) if any endpoint changed
  • Screenshots or screen recordings attached for any UI changes

Summary by CodeRabbit

  • Chores
    • Updated the development deployment setup to use the dedicated dev environment.
    • Changed the default infrastructure location to Germany West Central for new deployments.

@georges-nasrallah georges-nasrallah self-assigned this Jul 2, 2026
@georges-nasrallah georges-nasrallah added the bug Something isn't working label Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f402547e-14a2-4b22-a413-dd9fec12b724

📥 Commits

Reviewing files that changed from the base of the PR and between ad3eadc and 71c795d.

📒 Files selected for processing (2)
  • .github/workflows/cd-dev.yml
  • infra/terraform/variables.tf

📝 Walkthrough

Walkthrough

This PR makes two unrelated single-line configuration changes: it assigns the dev GitHub Actions environment to the deploy job in the cd-dev workflow, and it updates the default value of the location Terraform variable from westeurope to germanywestcentral.

Changes

CD Workflow Environment Binding

Layer / File(s) Summary
Assign deploy job to dev environment
.github/workflows/cd-dev.yml
Adds environment: dev to the deploy job configuration.

Terraform Default Location Change

Layer / File(s) Summary
Update default Terraform location
infra/terraform/variables.tf
Changes the location variable default from westeurope to germanywestcentral.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately mentions the Terraform region fix, one of the main changes.
Description check ✅ Passed The description follows the template and includes summary, context, changes, testing steps, and checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch PROJ-I08/fix-terraform-region

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@georges-nasrallah georges-nasrallah merged commit 8915d83 into main Jul 2, 2026
12 checks passed
@georges-nasrallah georges-nasrallah deleted the PROJ-I08/fix-terraform-region branch July 2, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants