Launcher improvements - #10
Open
nkleiner wants to merge 18 commits into
Open
Conversation
… It's bad, and doesn't work. Gonna change that
…nd see them run properly. Still need some UI improvements to help with understanding when things are actually running, but overall this is a good base level of functionality
…on that lets you initialize an empty set of fields to fill. Also added status icons that show whether services are running, though the logic is a bit dumb in the sense that it just assumes it's running when the launcher starts ARES and isn't when ARES is stopped.
…while they're running. Also updated the running logic to more properly monitor the real status of the processes rather than assume they're running
…etimes it gets stuck in a state where the restart doesn't actually kill the old process, causing the new process to fail starting due to a port conflict.
…n't think it to be overly necessary
…blems with python processes lingering in the event of abnormal shutdowns, this fixes that
…problematic spots that could have caused problems with cross-platform compatability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.