Analysis improvements - #224
Merged
Merged
Conversation
# Conflicts: # Ares.Core/Execution/Executors/CampaignExecutor.cs # Ares.Core/Planning/PlanningHelper.cs
# Conflicts: # Ares.Core/Ares.Core.csproj # Ares.Core/Planning/PlanningHelper.cs # UI/UI.csproj
…rds compatability
# Conflicts: # Ares.Core/Ares.Core.csproj # Ares.Core/DataManagement/DataMappers/CampaignDatasetGenerator.cs # UI/UI.csproj
…sed to the planner during campaigns. Still need to round out the logic for populating objective info for planners, but currently am successfully seeing analyzers report exactly what objectives they return and then successfully marking what objectives to use for planning and saving that off to experiment templates.
…l closed loop run, where the analyzer provided a schema defining it's expected objective outputs as well as the objective outputs themselves, and the planner was able to successfully receive a list of objective outputs.
…ve outputs are selected (either because the analyzer doesn't support advertising it's objective outputs or the user simply didn't select any) all objectives are passed to the planner for use.
…sometimes caused errors.
…a few loading quirks that could result in erradic behavior.
…kely going to do the same for planners, analyzers and devices. Also made the UI for showing the errors much cleaner with an expansion button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.