Refactor model loading in distillation to remove Tunix adapter. #2927
+43
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the distillation trainer to remove the
TunixMaxTextAdapterdependency, enabling direct control over model execution and configuration.Key Changes:
nnx.Moduleloading viaget_maxtext_model.create_forward_fnto generate distinct forward functions for Student and Teacher. This correctly bindsenable_dropoutfrom the config, allowing the Student to train with dropout while keeping the Teacher deterministic.teacher_overrides.load_parameters_pathis now mandatory to ensure reproducibility.Tests
Verified locally with the following command:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.