Fix Codecov Coverage Issue #2934
Open
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shuang-cnt
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Shuang-cnt
force-pushed
the
codecov_dummy
branch
from
fa901d3 to
7a4e420
Compare
shralex
approved these changes
Jan 14, 2026
ecnal-cienet
force-pushed
the
codecov_dummy
branch
from
cf15225 to
1b094b5
Compare
| runs-on: ${{ inputs.cloud_runner != '' && inputs.cloud_runner || fromJson(format('["self-hosted", "{0}", "{1}"]', inputs.device_type, inputs.device_name)) }} | ||
| container: | ||
| image: gcr.io/tpu-prod-env-multipod/maxtext-unit-test-${{ inputs.device_type == 'cpu' && 'tpu' || inputs.device_type }}:${{ inputs.image_type != '' && inputs.image_type }} | ||
| image: gcr.io/tpu-prod-env-multipod/maxtext-unit-test-${{ inputs.device_type == 'cpu' && 'tpu' || inputs.device_type }}:${{ inputs.image_type != '' && inputs.image_type || 'latest' }} |
Collaborator
There was a problem hiding this comment.
What is the need to addlatest tag?
This docker image doesn't have latest tag.
| $SPLIT_ARGS | ||
| env: | ||
| PYTHONPATH: "${{ github.workspace }}/src" | ||
| - name: Check Coverage Output |
Collaborator
There was a problem hiding this comment.
This Check Coverage Output step runs multiple times because run_tests_against_package.yml is called separately for CPU, TPU, and GPU tests by the build_and_test_maxtext.yml workflow. Please move this to a different workflow.
| echo "--- Coverage XML (first 50 lines) ---" | ||
| head -n 50 coverage.xml | ||
| echo "--- End Coverage XML ---" | ||
| - name: Upload results to Codecov |
Collaborator
There was a problem hiding this comment.
We should move this step as well to this new workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Codecov shows coverage is 0, so this PR is used to fix the issue.
Tests
We add a sample math_utils code and test to check the results.
CodeCov branch report
CodeCov PR report
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.