Fix rngs used for training #2938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Also fix the unit tests to make them run in different tpu VMs
RissyRan
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
aireenmei
approved these changes
Jan 14, 2026
NuojCheng
approved these changes
Jan 14, 2026
RissyRan
reviewed
Jan 14, 2026
| """ | ||
| # Create a mesh shape for a 5D mesh. | ||
| devices = np.array(jax.devices()).reshape((4, 1, 1, 1, 1)) | ||
| devices = np.array(jax.devices()[:4]).reshape((4, 1, 1, 1, 1)) |
Collaborator
There was a problem hiding this comment.
I guess you met issue when testing on other tpu topology? Shall we instead do something like
num_devices = jax.device_count()
devices = np.array(jax.devices()).reshape((num_devices, 1, 1, 1, 1))
| per_device_batch_size_increment=1.0, | ||
| global_rampup_samples=60, | ||
| # global_rampup_samples: (rampup increment number) * (Samples for initial 5 steps) | ||
| global_rampup_samples=3 * (1 * jax.device_count() * 5), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix rngs used for training.
Also fix the unit tests to make them run in different tpu VMs
Tests
Run a training successfully.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.