Enabling gradient clipping in sft.sft_trainer #2942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maxtext.sft.sft_traineroptimizer.gradient_clipping_thresholdhas no effect inMaxtext.sft.sft_trainerqwen3-4bSFT workload, and it significantly accelerated training convergence.FIXES: b/475340254
Tests
0.381to0.069Checklist
gemini-reviewlabel.