Skip to content

Ensure all logger instances in pathwaysutils are _logger #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Ensure all logger instances in pathwaysutils are _logger #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pathwaysutils/persistence/orbax_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from pathwaysutils.persistence import helper


logger = logging.getLogger(__name__)
_logger = logging.getLogger(__name__)

ParamInfo = type_handlers.ParamInfo
SaveArgs = type_handlers.SaveArgs
Expand Down Expand Up @@ -197,7 +197,7 @@ async def deserialize(
mesh_axes.append(sharding.spec)
shardings.append(sharding)
if arg.global_shape is None or arg.dtype is None:
logger.warning(
_logger.warning(
"Shape or dtype not provided for restoration. Provide these"
" properties for improved performance."
)
Expand Down Expand Up @@ -279,7 +279,7 @@ def register_pathways_handlers(
array_metadata_store: array_metadata_store_lib.Store | None = None,
):
"""Function that must be called before saving or restoring with Pathways."""
logger.debug(
_logger.debug(
"Registering CloudPathwaysArrayHandler (Pathways Persistence API)."
)
type_handlers.register_type_handler(
Expand Down
Loading