Skip to content

Make CloudPathwaysArrayHandler compatible with async directory creation feature in orbax. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 24, 2025
Merged

Make CloudPathwaysArrayHandler compatible with async directory creation feature in orbax. #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions pathwaysutils/persistence/orbax_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,18 @@ def __init__(
raise ValueError("OCDBT not supported for Pathways.")
super().__init__()

async def _background_serialize(
self,
values: Sequence[jax.Array],
locations: Sequence[str],
names: Sequence[str],
) -> None:
"""Uses Pathways Persistence API to serialize a jax array."""
f = functools.partial(helper.write_one_array, timeout=self._read_timeout)
futures_results = list(map(f, locations, names, values))
for future_result in futures_results:
future_result.result()

async def serialize(
self,
values: Sequence[jax.Array],
Expand All @@ -76,8 +88,12 @@ async def serialize(
raise ValueError("Casting during save not supported for Pathways.")

locations, names = extract_parent_dir_and_name(infos)
f = functools.partial(helper.write_one_array, timeout=self._read_timeout)
return list(map(f, locations, names, values))
return [
future.CommitFutureAwaitingContractedSignals(
self._background_serialize(values, locations, names),
name="cloud_pathways_array_handler",
)
]

async def deserialize(
self,
Expand Down