Conversation
…rnally consistent
Collaborator
|
I have pushed changes to:
Note: Codex was used; for example to translate the Makefile and replace all links |
wildsm
approved these changes
Jul 15, 2026
wildsm
left a comment
Collaborator
There was a problem hiding this comment.
I have reviewed all changes.
make install succeeded.
make install-dev succeeded.
make test passed, with the expected warning:
Warning: CoverageWarning: No data was collected. (no-data-collected); see https://coverage.readthedocs.io/en/7.14.0/messages.html#warning-no-data-collected
It otherwise passed with this coverage output:
================================= tests coverage ==================================
_________________ coverage: platform linux, python 3.12.3-final-0 _________________
Name Stmts Miss Cover Missing
--------------------------------------------------------
basetemplate/__init__.py 4 4 0% 8-12
--------------------------------------------------------
TOTAL 4 4 0%
Coverage HTML written to dir htmlcov
make test-cov also passed with the same warning.
make lint passed:
uv run ruff check .
All checks passed!
make format passed:
uv run ruff format .
3 files left unchanged
make type-check passed:
uv run mypy basetemplate
Success: no issues found in 1 source file
All actions are passing.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modernize Python template with uv and ruff to establish best practices and improve developer experience across the organization.
This PR updates the template to use modern, industry-standard Python tooling:
Key improvements:
Type of Change
How Has This Been Tested?
uv syncto verify lock file generationChecklist
Changes Summary
Configuration Files:
pyproject.toml: Migrated to PEP 735 dependency-groups, added ruff and mypy configurationuv.lock: Generated for reproducible installs.gitignore: Added .ruff_cache/Workflow Files:
.github/workflows/ci.yml: Replaced pip+black+flake8+isort with uv+ruff, added check-lock job, enabled caching.github/workflows/publish.yml: New example workflow for building and publishing packagesRemoved:
requirements.txtandrequirements-dev.txt(replaced by uv.lock and pyproject.toml)Documentation:
README.md: Updated Quick Start, Prerequisites, and Development sections with uv/ruff instructionsAdditional Context
This template now provides teams with:
Teams can adopt this incrementally or fork and customize as needed. All tools are optional and can be replaced with alternatives in forked repositories.