feat: add setters to toggle suppression during a session by jim-smith · Pull Request #43 · AI-SDC/ACRO-R

jim-smith · 2026-02-02T12:54:08Z

No description provided.

for more information, see https://pre-commit.ci

codecov · 2026-02-02T12:57:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8069069) to head (9d49e3a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          109       115    +6     
=========================================
+ Hits           109       115    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jim-smith · 2026-02-02T13:29:21Z

@rpreen @JessUWE there ar glitched when GitHub it tries to run the tests on their runners - but it is nowt to do without ur code - al works fine on may Mac, and error logs show it is to do with their runners.

for more information, see https://pre-commit.ci

…estadd-setters-so-user-can-toggle-suppression-during-a-session' into 42-new-feature-requestadd-setters-so-user-can-toggle-suppression-during-a-session

for more information, see https://pre-commit.ci

rpreen

The macOS error looks like some kind of CI cache issue that should resolve later.

rpreen · 2026-02-02T14:46:47Z

NEWS.md

+* Added support for toggling suppression dynamically during session via   ```acro_enable_supression()```
+  and ```acro_disable_suppression()```
+* Improved documentation in package and at [sacro-tools.org](sacro-tools.org)
+* AddedSupport for variable names with spaces when calling crosstab


typo here? "AddedSupport"

rpreen · 2026-02-02T14:47:47Z

NEWS.md

+* Added support for installation via conda
+* Added support for specifying config files when acro session is started
+* Added support for specifying whether suppression is on or off when acro session is started
+* Added support for toggling suppression dynamically during session via   ```acro_enable_supression()```


Only need single backticks for inline.

rpreen · 2026-02-02T14:49:04Z

inst/WORDLIST

@@ -1,41 +1,39 @@
 ADR
 Acknowledgement
+AddedSupport


rpreen

See comments.

jim-smith · 2026-02-02T15:46:54Z

@rpreen fixed typos and number of ticks as per helpful comments.

I've spent a while trying to understand why the CI runners are failing for macosx and can't figure it out.
R has moved to a new version rhubv2 which is GitHub based and has dedicated runners on there and isn't macosx latest.
Don;t know how much effort it is to set that up? https://r-hub.github.io/rhub/reference/rhubv2.html

or do we just submit to CRAN without the checks on macosx?

…estadd-setters-so-user-can-toggle-suppression-during-a-session' into 42-new-feature-requestadd-setters-so-user-can-toggle-suppression-during-a-session

Signed-off-by: Jim-smith <jim-smith@users.noreply.github.com>

rpreen

Merge when ready. The macOS CI cache will probably clear on a later run.

jim-smith added 2 commits February 2, 2026 12:27

feat: Adds functions enable_suppression() and disable_suppression()

d9a310c

cleaning code

2ab4ba0

jim-smith linked an issue Feb 2, 2026 that may be closed by this pull request

[New Feature Request]Add setters so user can toggle suppression during a session #42

Closed

[pre-commit.ci] auto fixes from pre-commit.com hooks

2734dfb

for more information, see https://pre-commit.ci

adding files tweaked by rcheck

e4e14c6

jim-smith requested review from JessUWE and rpreen and removed request for rpreen February 2, 2026 13:28

jim-smith and others added 2 commits February 2, 2026 13:37

updated news

9751737

[pre-commit.ci] auto fixes from pre-commit.com hooks

50f3875

for more information, see https://pre-commit.ci

jim-smith changed the title ~~42 new feature requestadd setters so user can toggle suppression during a session~~ 42 [feat] add setters so user can toggle suppression during a session Feb 2, 2026

adding rhub commands to pre-submission-check

89693e4

rpreen changed the title ~~42 [feat] add setters so user can toggle suppression during a session~~ feat: add setters to toggle suppression during a session Feb 2, 2026

jim-smith and others added 3 commits February 2, 2026 14:17

Merge remote-tracking branch 'refs/remotes/origin/42-new-feature-requ…

0f19d0c

…estadd-setters-so-user-can-toggle-suppression-during-a-session' into 42-new-feature-requestadd-setters-so-user-can-toggle-suppression-during-a-session

commented out old version of rhub

5925943

[pre-commit.ci] auto fixes from pre-commit.com hooks

6c26432

for more information, see https://pre-commit.ci

rpreen approved these changes Feb 2, 2026

View reviewed changes

rpreen reviewed Feb 2, 2026

View reviewed changes

inst/WORDLIST Outdated

@@ -1,41 +1,39 @@

ADR

Acknowledgement

AddedSupport

Copy link

Collaborator

rpreen Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd

rpreen requested changes Feb 2, 2026

View reviewed changes

fixing typos and quote levels in markdown

99ebe03

jim-smith added 3 commits February 2, 2026 15:48

Merge remote-tracking branch 'refs/remotes/origin/42-new-feature-requ…

0ce8ff6

…estadd-setters-so-user-can-toggle-suppression-during-a-session' into 42-new-feature-requestadd-setters-so-user-can-toggle-suppression-during-a-session

version should be 1.7

88277ef

Remove version 0.1.8 entry from NEWS.md

9d49e3a

Signed-off-by: Jim-smith <jim-smith@users.noreply.github.com>

rpreen self-requested a review February 2, 2026 15:59

rpreen approved these changes Feb 2, 2026

View reviewed changes

jim-smith merged commit a9bf7c1 into main Feb 2, 2026
11 of 13 checks passed

jim-smith deleted the 42-new-feature-requestadd-setters-so-user-can-toggle-suppression-during-a-session branch February 2, 2026 16:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add setters to toggle suppression during a session#43

feat: add setters to toggle suppression during a session#43
jim-smith merged 14 commits intomainfrom
42-new-feature-requestadd-setters-so-user-can-toggle-suppression-during-a-session

jim-smith commented Feb 2, 2026

Uh oh!

codecov bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

jim-smith commented Feb 2, 2026

Uh oh!

rpreen left a comment

Uh oh!

rpreen Feb 2, 2026

Uh oh!

rpreen Feb 2, 2026

Uh oh!

rpreen Feb 2, 2026

Uh oh!

rpreen left a comment

Uh oh!

jim-smith commented Feb 2, 2026

Uh oh!

rpreen left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jim-smith commented Feb 2, 2026

Uh oh!

codecov bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jim-smith commented Feb 2, 2026

Uh oh!

rpreen left a comment

Choose a reason for hiding this comment

Uh oh!

rpreen Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rpreen Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rpreen Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rpreen left a comment

Choose a reason for hiding this comment

Uh oh!

jim-smith commented Feb 2, 2026

Uh oh!

rpreen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Feb 2, 2026 •

edited

Loading