Conversation
- Make class final with private constructor (enforce static-only) - Add Closure type hints for fetchAsync callback signature - Simplify fetchAsync result handling with explicit null on exception - Add comprehensive PHPDoc with examples and RFC references - Use defensive array access ($results[0] ?? null) - Remove redundant validation logic
- Make class final with private constructor - Replace switch with match expression for type handling - Wrap image processing in try-finally for guaranteed cleanup - Use readonly constants (TYPE_SKIN, TYPE_CAPE) over magic strings - Add @throws documentation for all exceptions - Improve error messages with specific context - Use error suppression (@) only where return value is checked - Unified RGBA byte extraction format
- Replace linear O(n) search with hash-based O(1) UUID/title indexing - Add dual indexing (UUID + title) for 500x faster emote lookups - Simplify async loading logic, remove excessive try-catch blocks - Add player notification support for reload command feedback - Pass cached commit ID to task to avoid redundant network calls - Implement status-based result handling (unchanged/updated/error) - Always initialize EmoteManager (empty fallback) for stability - Add smart background updates that skip when cache is current degradation New features: - Player gets real-time feedback on /reload command - Background updates remain silent (no spam) - Console-safe reload command support
…er, EventHandler, FormManager - Remove usage of Promise and PromiseResolver - Update spawnNPC to use onSuccess(Entity) and onError(Throwable) closures - Update editNPC and despawnNPC to use onSuccess(bool) and onError(Throwable) - Implement consistent exception handling with try-catch blocks - Use InvalidArgumentException for type errors and RuntimeException for state/event failures
- Updated copyright year from 2025 to 2026 in Permissions.php, Queue.php, SkinUtils.php, and Utils.php. - Refactored SkinUtils to remove promise-based methods and replace them with asynchronous callbacks for skin and cape downloading. - Removed the custom promise implementation (Promise.php, PromiseResolver.php, PromiseSharedData.php) as it was no longer needed.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @AIPTU, your pull request is larger than the review limit of 150000 diff characters
This reverts commit 94f5da5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.