Skip to content

[Design update] Update Design of Judge Model and GEdit Bench in design doc#214

Open
SJTUyh wants to merge 4 commits intoAISBench:masterfrom
SJTUyh:design
Open

[Design update] Update Design of Judge Model and GEdit Bench in design doc#214
SJTUyh wants to merge 4 commits intoAISBench:masterfrom
SJTUyh:design

Conversation

@SJTUyh
Copy link
Collaborator

@SJTUyh SJTUyh commented Mar 23, 2026

Thanks for your contribution; we appreciate it a lot. The following instructions will make your pull request healthier and help you get feedback more easily. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
感谢您的贡献,我们非常重视。以下说明将使您的拉取请求更健康,更易于获得反馈。如果您不理解某些项目,请不要担心,只需提交拉取请求并从维护人员那里寻求帮助即可。

PR Type / PR类型

  • Feature(功能新增)
  • Bugfix(Bug 修复)
  • Docs(文档更新)
  • CI/CD(持续集成/持续部署)
  • Refactor(代码重构)
  • Perf(性能优化)
  • Dependency(依赖项更新)
  • Test-Cases(测试用例更新)
  • Other(其他)

Related Issue | 关联 Issue
Fixes #(issue ID / issue 编号) / Relates to #(issue ID / issue 编号)

🔍 Motivation / 变更动机

Please describe the motivation of this PR and the goal you want to achieve through this PR.
请描述您的拉取请求的动机和您希望通过此拉取请求实现的目标。

Update Design of Judge Model and GEdit Bench in design doc

📝 Modification / 修改内容

Please briefly describe what modification is made in this PR.
请简要描述此拉取请求中进行的修改。

Update Design of Judge Model and GEdit Bench in design doc

📐 Associated Test Results / 关联测试结果

Please provide links to the related test results, such as CI pipelines, test reports, etc.
请提供相关测试结果的链接,例如 CI 管道、测试报告等。
NA

⚠️ BC-breaking (Optional) / 向后不兼容变更(可选)

Does the modification introduce changes that break the backward compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
是否引入了会破坏下游存储库向后兼容性的更改?如果是,请描述它如何破坏兼容性,以及下游项目应该如何修改其代码以保持与此 PR 的兼容性。

⚠️ Performance degradation (Optional) / 性能下降(可选)

If the modification introduces performance degradation, please describe the impact of the performance degradation and the expected performance improvement.
如果引入了性能下降,请描述性能下降的影响和预期的性能改进。

🌟 Use cases (Optional) / 使用案例(可选)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
如果此拉取请求引入了新功能,最好在此处列出一些用例并更新文档。

✅ Checklist / 检查列表

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues. / 使用预提交或其他 linting 工具来修复潜在的 lint 问题。
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests. / 修复的 Bug 已完全由单元测试覆盖,导致 Bug 的情况应在单元测试中添加。
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness. / 此拉取请求中的修改已完全由单元测试覆盖。如果不是,请添加更多单元测试以确保正确性。
  • All relevant documentation (API docs, docstrings, example tutorials) has been updated to reflect these changes. / 所有相关文档(API 文档、文档字符串、示例教程)已更新以反映这些更改。

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects. / 如果此拉取请求对下游或其他相关项目有潜在影响,应在那些项目中测试此 PR。
  • CLA has been signed and all committers have signed the CLA in this PR. / CLA 已签署,且本 PR 中的所有提交者均已签署 CLA。

👥 Collaboration Info / 协作信息

  • Suggested Reviewers / 建议审核人: @xxx
  • Relevant Module Owners / 相关模块负责人: @xxx
  • Other Collaboration Notes / 其他协作说明:

🌟 Useful CI Command / 实用的CI命令

Command / 命令 Introduction / 介绍
/gemini review Performs a code review for the current pull request in its current state by Gemini. / 对当前拉取请求在当前状态下由 Gemini 执行代码审核。
/gemini summary Provides a summary of the current pull request in its current state by Gemini. / 对当前拉取请求在当前状态下由 Gemini 提供摘要。
/gemini help Displays a list of available commands of Gemini. / 显示 Gemini 可用命令的列表。
/readthedocs build Triggers a build of the documentation for the current pull request in its current state by Read the Docs. / 触发当前拉取请求在当前状态下由 Read the Docs 构建文档。

@github-actions github-actions bot added the other label Mar 23, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求主要更新了AISBench的设计文档,详细阐述了新增的裁判模型评估能力和GEdit基准测试支持。这些更新旨在扩展平台的评估范围,使其能够更全面地衡量大型语言模型和多模态模型的性能,特别是在文本正确性判断和图片编辑质量评估方面。文档的更新涵盖了从特性需求到系统架构、数据流、实现原理及兼容性分析等多个方面,为理解和使用这些新功能提供了全面的指导。

Highlights

  • 裁判模型评估能力: 文档更新详细描述了AISBench支持LLM和LMM裁判模型对文本答案正确性和多模态输出进行评估的能力,并强调了裁判模型与被测模型的解耦部署。
  • GEdit Bench支持: 设计文档新增了对GEdit数据集的支持,用于评估多模态生成类模型的图片编辑能力,包括语义一致性(SC)和感知质量(PQ)两阶段评估。
  • 设计文档结构更新: 更新了设计文档中的图表标题、特性概述、特性需求、使用场景、影响分析、实现原理和用例分解等多个章节,以反映裁判模型和GEdit Bench的新增内容。
  • 系统架构与数据流更新: 系统架构图和数据流时序图已更新,以包含裁判模型工作流、裁判数据集加载器、裁判模型包装器和裁判评估器等新组件,并新增了裁判模型测评数据流时序图。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次PR主要更新了设计文档,详细阐述了裁判模型(Judge Model)和GEdit Bench相关的新功能设计。整体上,文档补充了大量关于新特性的架构、数据流、实现原理和使用场景等细节,显著提升了文档的完整性和清晰度。

我发现了一些文档中的不一致和拼写错误,具体请见行级评论。修正这些问题将有助于进一步提高文档的质量和可读性。

4. 查看评估结果,与OpenCompass结果对比

#### 场景2:多模态模型全面评估
#### 场景2:多模态生成类模型全面评估
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

章节标题似乎与内容不符。标题修改为“多模态生成类模型全面评估”,但该场景下的子场景(如视觉问答、视频理解、OCR等)均为理解类任务,而非生成类任务。这可能会让读者感到困惑。建议将标题改回“多模态模型全面评估”或修改为“多模态理解类模型全面评估”以保持一致性。

Suggested change
#### 场景2:多模态生成类模型全面评估
#### 场景2:多模态理解类模型全面评估

- 目前多模态生成类模型的开源服务化框架(vllm omni)还不成熟,当前工具只适配了基于昇腾NPU的Qwen-Image-Edit模型后端
- GEdit评估需要两阶段裁判模型推理:SC(语义一致性)评估和PQ(感知质量)评估

### 2.3.1硬件限制
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

此处的章节标题编号 2.3.1 与前面的章节 2.3.1 系统位置及周边接口 重复。这似乎是一个文档结构或编号错误,建议修正为正确的序号(例如 2.3.7),以保证文档的结构清晰和一致性。

- 预期结果:使用环境变量的API Key(优先级更高)

# 6.Use Case三至六实现
# 6.Use Case三至七实现
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

章节标题为“Use Case三至七实现”,但接下来的内容实际包含了对“Use Case八”的实现说明。为了保持标题与内容的一致性,建议将标题修改为“Use Case三至八实现”。

Suggested change
# 6.Use Case三至七实现
# 6.Use Case三至八实现


- `EncodingTimeCalculator.calculate()`: 计算encoding阶段耗时
- `TraceReplayCalculator.replay()`: 流量负载复现
- `TraceReplayCalculator.replay()`: 流量负载复
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

此处有拼写错误,“流量负载复”应为“流量负载复现”。

Suggested change
- `TraceReplayCalculator.replay()`: 流量负载复
- `TraceReplayCalculator.replay()`: 流量负载复现

- GEdit评估依赖LMM裁判模型进行SC和PQ评估
- 裁判模型需要具备图片理解能力(如Qwen2.5-VL-7B)
- 裁判模型推理与被测模型推理解耦,可部署在不同硬件平台
- 裁判模型推理结果通过judger(裁判)标识,与常规评估结果区分现
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

此处有拼写错误,“区分现”应为“区分”。

Suggested change
- 裁判模型推理结果通过judger(裁判)标识,与常规评估结果区分现
- 裁判模型推理结果通过judger(裁判)标识,与常规评估结果区分

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant