fix: move examples/ inside hackagent package for correct wheel packaging#380
Merged
Merged
Conversation
The examples/ directory was located at the repo root, outside the hackagent Python package. When installed from PyPI or a wheel, the examples were never included, causing 'hackagent examples ollama' to fail with 'Example directory not found'. Move examples/ to hackagent/examples/ so it is bundled inside the Python package. The existing _resolve_example_dir() second candidate already resolves correctly via parents[2]/examples/ for both editable and installed layouts. Also: - Add artifacts glob in pyproject.toml to ensure non-Python files (.md, .pdf, .txt) in examples/ are included in the wheel - Update tests/integration/conftest.py to find google_adk examples at the new path - Update codecov.yml ignore pattern to match new examples path Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples/ directory was located at the repo root, outside the hackagent Python package. When installed from PyPI or a wheel, the examples were never included, causing 'hackagent examples ollama' to fail with 'Example directory not found'.
Move examples/ to hackagent/examples/ so it is bundled inside the Python package. The existing _resolve_example_dir() second candidate already resolves correctly via parents[2]/examples/ for both editable and installed layouts.
Also: