[pull] main from enyo:main - #14
Merged
Merged
Conversation
`transformFile` is asynchronous, and a file is already UPLOADING while it runs. For that window it has no `xhr`, which broke `cancelUpload` twice over. `_getFilesWithXhr(file.xhr)` was called with `undefined` and matched every file whose `xhr` was also undefined -- that is, everything still queued. Cancelling one upload set them all to CANCELED and emitted a `canceled` event for each. Group by the request only when there is one; without it the file is its own group. Then, because nothing rechecked the status, the transform callback went on to upload the file the user had just cancelled. Bail out instead when every file in the batch has been cancelled. Refs #2231
Don't take the queue down when cancelling a transforming file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )