[pull] main from enyo:main - #15
Merged
Merged
Conversation
`submitRequest` sent `files[0]` -- the file as it was dropped -- for a non-chunked binary upload, while the data that should go on the wire sat unused in `dataBlocks[0].data`. Anything `transformFile` produced was discarded, which silently includes `resizeWidth` and `resizeHeight`: the preview showed a resized image and the server received the full-size original. The chunked branch immediately above already used the chunk's own `dataBlock`, and form-data uploads append it too. `submitRequest` takes `dataBlocks` to reach it, optional so an existing caller passing three arguments keeps working. Its `formData` parameter is now `FormData | null`, which is what the binary path has always passed -- that was a `null as any` at the call site.
Send the transformed file on binaryBody uploads
Version packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )