Skip to content

feature/dashboard - #86

Open
rashidaysher wants to merge 2 commits into
ALCOpenSource:developfrom
rashidaysher:feature/dashboard3
Open

rashidaysher wants to merge 2 commits into
ALCOpenSource:developfrom
rashidaysher:feature/dashboard3

Conversation

@rashidaysher

Copy link
Copy Markdown

Solved issue #4

@rashidaysher

Copy link
Copy Markdown
Author

image

@raoularavel

Copy link
Copy Markdown
Collaborator

Awesome Job @rashidaysher ,
Just a few thing to correct.

@raoularavel

raoularavel commented May 19, 2023

Copy link
Copy Markdown
Collaborator

Remove unused import

Screenshot 2023-05-19 at 15 38 56

@raoularavel

raoularavel commented May 19, 2023

Copy link
Copy Markdown
Collaborator

Do proptype validation.

Before you export the ProgramItem,

ProgramItem.propTypes = {
date: PropTypes.string,
progress: PropTypes.number,
value: PropTypes.string,
};

Remember to import PropTypes from "prop-types"

Screenshot 2023-05-19 at 15 41 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants