Conversation
iraj465
marked this pull request as ready for review
September 18, 2026 01:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEAK can receive Hyperloom's latest accepted source snapshots and still import an installed regular package. Sparse snapshots also cannot represent a deleted module. The resulting benchmark can measure a different baseline from the one in the handoff. This change consumes a versioned, complete source bundle and requires proof for the selected measurements and replay before returning an eligible source-bearing result.
The interface validates accepted layer coverage, complete file hashes/modes, import ownership and deletions, stages immutable source and canonical helpers into the evaluation directory, and preserves the import order: verification bootstrap, GEAK-authored overlay, accepted upstream source, backend defaults, inherited paths. Publication supports NFS through an exclusive destination claim and manifest-last publication; concurrent incomplete claims and interrupted copies are refused without replacement.
The serving Python processes provide identity-bound observations around the timed hot rounds. Measurement records bind the exact launch capsule, source request, overlay inventory, raw measurements and summary. Persisted acceptance additionally requires confirmed teardown. Normalization verifies the selected Setup and fresh Director measurements, then stages an immutable replay wrapper. Missing proof remains diagnostic and cannot become an accepted gain or a permanent knowledge export. Per-kernel source attribution is explicitly unavailable until each operation has its own measurement provenance.
Version 1 supports regular pure-Python packages with unambiguous import ownership. Unsupported compiled artifacts, namespace/package deletion, unresolved source coverage and persistent unobserved workers are refused. The runtime covers observed persistent processes and guarded Python imports; native process creation bypassing Python auditing and arbitrary dynamic execution are outside that contract. A source seal does not certify GPU correctness, model/workload identity or native accuracy evaluation. Handoffs without source changes retain their existing behavior.
Refs #475. Paired producer: AMD-AGI/Hyperloom#1562 constructs the versioned descriptor. This is separate from PR452's launch-setting transport and PR476's optional post-measure callback. It does not change the completed online A/B or establish PR452-specific performance gains.
Validation:
3903818c: 2,498 tests and 90 subtests passed, 5 skipped; 97.05% coverage clears the unchanged 97% gate. Python 3.11.16 / Node 20.20.2; all blocking workflow steps passed. Ruff retains the same 1,054 existing advisory findings as base, with no findings in the new Python files.The first full run is retained as failed: an existing recovery test leaked ignored SIGTERM into later tests, and a renamed-interpreter fixture could not locate the Python 3.11 standard library. Test-only corrections restore the original signal disposition and verify the renamed worker actually starts. Controlled reproductions and the corrected ordered 169-test suite passed before the final full run; runtime cleanup behavior and assertions were unchanged.