feat(baremetal): bump vLLM default to 0.28.0 with glibc gate - #1476
Conversation
ReviewWhat this PR does: bumps the bare-metal BlockingThe 0.28.0 wheels raise the glibc floor to 2.39, so bare-metal vLLM install now hard-fails on Ubuntu 22.04 — The index contents differ from 0.27.1 in more than the version:
Failure path (isolated mode, the default for vLLM): This breaks two paths the repo documents as supported:
Note the docker path is unaffected — the image ships vLLM prebuilt. Only the bare-metal/isolated-venv path regresses. Suggested resolution (either is fine, but the PR shouldn't land as-is):
Verification performed
No other blocking issues: the doc/example string replacements are complete and consistent with the new default, and the version-consistency test still passes against them. |
Updates VLLM_VERSION default in install_baremetal.sh, plus every doc/example that names the pinned version: docs/compatibility.rst, docs/install/install.md, the four example SKILL.md recipes, assets/slurm/models.tsv, and the test_baremetal_doc_version_consistency.py comments that mirror it. VLLM_ROCM_VARIANT stays rocm723: wheels.vllm.ai only publishes a rocm723 build for 0.28.0, same as 0.27.1. Verified against the real upstream vLLM v0.28.0 tag that TraceLens' config_vllm_v0.28.0.patch applies cleanly via git apply --check, so the TraceLens vLLM profiler-config patch path is unaffected by this bump (unlike the SGLang v0.5.18 case, see docs/compatibility.rst). Also confirmed the vllm/vllm-openai-rocm:v0.28.0 Docker image exists. Ran the full provenance/manifest/server-patcher/baremetal-doc test suite (347 tests) plus the doc-consistency guard; all pass except one pre-existing unrelated failure (test_baremetal_profiler_hotfix_accepts_an_atom_only_host, reproduced unmodified on main).
Raise the bare-metal vLLM default to 0.28.0, document Ubuntu 24.04 as the recommended host OS, gate SGLang profiler hotfix to ROCm 7.2.0 only, and teach hyperloom-setup to steer older Ubuntu hosts away from vLLM 0.28.0+ installs.
4ad65c7 to
595d929
Compare
Request changesPlease keep this PR to the vLLM default upgrade and make the installation boundary authoritative. Do not add further prompt rules or version-inference fallbacks.
This produces one small, deterministic vLLM-default change now; the host-library mutation can then be reviewed independently against real stack evidence. |
Reject vLLM >= 0.28.0 installs when host glibc is below 2.39 (including check-only and dry-run), revert the SGLang hotfix gating to a follow-up PR, trim hyperloom-setup to installer-backed UX, and fix ruff format.
Install the graph replay probe from the already imported torch module instead of importing through its own hook. Isolate import hooks and exit callbacks in probe tests, and cover bounded repeated imports, lazy readiness, replay counting and cleanup without reducing test depth. Co-Authored-By: Claude <noreply@anthropic.com>
Problem
Fix
rocm723) and sync the pinned version across compatibility docs, install docs, example skills, and Slurm model metadata.install_vllm_framework()before any venv/pip work (including--check-only/--dry-run), with actionable guidance for Docker or a pre-0.28 override.hyperloom-setupto a short UX explanation of the installer gate; remove the unconditionalVLLM_VERSION=0.27.1from the normal vLLM command.torch.version.hip.Test plan
pytest src/hyperloom/inference_optimizer/tests/test_setup_cli.py -k "hotfix or glibc or vllm_install"pytest src/hyperloom/inference_optimizer/tests/test_baremetal_doc_version_consistency.pyruff format --check .