Skip to content

Migrate hyperloom-workload-optimizer skill to AMD-AGI/Hyperloom product repo - #1482

Open
danielholanda wants to merge 1 commit into
AMD-AGI:mainfrom
danielholanda:dholanda/federate_skill
Open

danielholanda wants to merge 1 commit into
AMD-AGI:mainfrom
danielholanda:dholanda/federate_skill

Conversation

@danielholanda

@danielholanda danielholanda commented Sep 10, 2026

Copy link
Copy Markdown

Description

This PR migrates hyperloom-workload-optimizer skill from amd/skills to AMD-AGI/Hyperloom product repo. The skill will continue to be part of the amd/skills catalog.

This enables AMD-AGI/Hyperloom to be the single source of truth (SSOT) for the hyperloom-workload-optimizer skill.

From now on amd/skills will simply mirror any changes made to this skill instead of requiring code to be changed at amd/skills.

@danielholanda
danielholanda requested a review from a team as a code owner September 10, 2026 14:45
@danielholanda

Copy link
Copy Markdown
Author

Looks like your linter is failing on the skill your team created on amd/skills. Feel free to make changes to this PR directly.

@johnl-amd

johnl-amd commented Sep 11, 2026

Copy link
Copy Markdown

The only red check is ruff, and it is formatting rather than anything
functional: two files want lines rejoined under this repo's 120-char limit.

uvx ruff@0.15.20 format skills/hyperloom-workload-optimizer/

That is 5 insertions and 16 deletions across scripts/preflight.py and
scripts/tests/test_preflight.py, and ruff check --force-exclude passes
cleanly afterwards. Verified on this branch.

Worth using ruff directly rather than pre-commit run here: the hook set needs
python3.11 and fails to build its virtualenv on a machine without it, whereas
ruff is a standalone binary and picks up [tool.ruff] from pyproject.toml
either way.

Everything else is green, and the skill's own checks pass: Structural, Discover
and Results. Behavioral is skipping, which is expected given machine.yml asks
for [mi300x, gpu, rocm] and that lane is dispatch-only.

lishuoshuo-amd added a commit that referenced this pull request Sep 17, 2026
The workflow and its test are named for the relationship they guard --
this folder is federated out of here -- rather than for the catalog on
the other end of it.

Both keep their own name rather than #1482's `AMD Skills Checks`, which
belongs to a workflow that really does call the catalog's skillscope
harness. This one asserts four rules itself, so borrowing that name would
show a green check for a harness that never ran.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants