Conversation
iraj465
marked this pull request as ready for review
September 17, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session Breakdown drops attempt, acceptance, and integration rows when an external identifier contains
:, such asaiter:paged_attention_ragged. The recorder treats the identifier as part of its key grammar and rejects the row even though the benchmark continues.Keep these identifiers opaque: hash the ordered identifier tuple into a reserved fragment-key namespace, preserving existing valid keys and the original IDs in row payloads. Recording, resumed updates, existence checks, event filtering, and late rejection now use the same stable key. Event IDs, row types, and empty natural IDs retain their existing validation.
2cc382a8(three robustness tests and one supervisor report test). No new failures.CHANGELOG.md: updated under Unreleased.